[2.x] Change Build workflow to always run#2580
Open
Exanite wants to merge 5 commits into
Open
Conversation
This file seems to have been causing issues ever. I remember a conversation about this last year and it's still popping up even now. If I recall, this was a file encoding issue. Hopefully a simple recommit fixes it.
This is because the branch protection rules of the repo requires this workflow to run and pass, thus blocking PRs from being merged when the workflow does not run.
Exanite
commented
May 17, 2026
| run: dotnet workload install android ios maccatalyst | ||
| - name: Validation Checks | ||
| if: ${{ github.repository != 'dotnet/Silk.NET' || !startsWith(github.ref, 'refs/tags/') }} | ||
| run: ./build.sh ValidateSolution |
Member
Author
There was a problem hiding this comment.
This is reordered since it's better to fail on the faster check.
| @@ -1,794 +1,794 @@ | |||
| # Summary | |||
Member
Author
There was a problem hiding this comment.
No actual changes. Just an encoding change since Git kept marking the file as changed when it wasn't. This is an old issue that I kept seeing and other people report having the same issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
The Build workflow is required to run and pass before a PR is allowed to be merged.
However, the workflow currently is excluded from running when the changes only modifies documentation files.
This blocks any PR that falls under the mentioned criteria from being merged.
This PR changes it so that the Build workflow always runs to fix that.
From what I can tell, there's no way to add a similar exclusion to the Ruleset enforcing this requirement.
Related issues, Discord discussions, or proposals
The reason for this PR is due to #2579 since the Build workflow is not triggering for that PR and causing the merging of that PR to be blocked.
This is the original PR that added those exclusions: #691
Further Comments
I also recommitted the Axis Input Devices proposal file. This file seems to be causing issues due to its encoding.
Github shows this as a massive change that modifies every line in the file, but the only change I made was committing it again.
It also looks like CI takes a long time to run, but since this is for 2.x which is slowing down in development, I'm not too concerned.
Edit: Maybe I am concerned. 1 hour is a bit long. Since the pack step takes the longest and isn't critical for verifying code behavior, I'll open another PR that splits the workflow into two, with the pack step being optional when merging PRs.
Edit 2: I tested this in #2585, but the difference is only 15 minutes. While that seems significant, it still takes 30+ minutes and is long enough to where a contributor would need to step away for a while. It's not worth the cost of duplicating workflows and adding more complexity just to speed up documentation changes.